[SYCL][CUDA] Fix non decorated address space for cuda joint_matrix.#9499
Closed
JackAKirk wants to merge 2 commits intointel:syclfrom
Closed
[SYCL][CUDA] Fix non decorated address space for cuda joint_matrix.#9499JackAKirk wants to merge 2 commits intointel:syclfrom
JackAKirk wants to merge 2 commits intointel:syclfrom
Conversation
Signed-off-by: JackAKirk <jack.kirk@codeplay.com>
Signed-off-by: JackAKirk <jack.kirk@codeplay.com>
3 tasks
Contributor
Author
|
closing because I don't think this patch is required. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Corresponding changes to #9244 for cuda backend. I think I should update the check_device_code tests to also check for local address space here too, but I should probably wait until #8874 is merged.
I haven't added any static asserts for private address space (which also isn't supported in the cuda backend), since we only ever call these load/store functions from joint_matrix_load/store which already has the appropriate asserts.